Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed delete_rule in compute-mig module for stateful disks #1078

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Fixed delete_rule in compute-mig module for stateful disks #1078

merged 2 commits into from
Jan 4, 2023

Conversation

rosmo
Copy link
Collaborator

@rosmo rosmo commented Jan 3, 2023

It was passing a boolean, but the resource expects a string.

@rosmo rosmo force-pushed the stateful-disks-deletion-rule-fix branch 2 times, most recently from 2699e02 to 22052ef Compare January 3, 2023 15:34
@rosmo rosmo force-pushed the stateful-disks-deletion-rule-fix branch from 22052ef to 5f7a4d3 Compare January 3, 2023 15:43
@rosmo rosmo force-pushed the stateful-disks-deletion-rule-fix branch from 00dce6f to ca4cb3b Compare January 3, 2023 20:53
@rosmo rosmo merged commit 344a0b0 into GoogleCloudPlatform:master Jan 4, 2023
@rosmo rosmo deleted the stateful-disks-deletion-rule-fix branch January 4, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosmo @ludoo